Improve Test Coverage for Dominant Color Images Plugin #1837
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #1837 +/- ##
==========================================
+ Coverage 65.89% 67.07% +1.18%
==========================================
Files 88 87 -1
Lines 6878 6873 -5
==========================================
+ Hits 4532 4610 +78
+ Misses 2346 2263 -83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
westonruter
added
no milestone
| @@ -42,7 +42,7 @@ public function test_dominant_color_metadata( string $image_path, array $expecte | |||
| * | |||
| * @dataProvider provider_get_dominant_color | |||
| * | |||
| * @covers ::dominant_color_get_dominant_color | |||
| * @covers helper::dominant_color_get_dominant_color | |||
There was a problem hiding this comment.
This doesn't seem right? The :: here refers to the global namespace.
| * @covers helper::dominant_color_get_dominant_color | |
| * @covers ::dominant_color_get_dominant_color |
There was a problem hiding this comment.
:: refers to the global namespace, and it works for rest of the functions however, when I'm trying to generate coverage report, for the functions where I've added helper & hooks it's showing 0 coverage without file reference.
Previous Result :
-
When setting annotation to
* @covers ::dominant_color_get_dominant_color&* @covers ::dominant_color_img_tag_add_dominant_color -
helper.php
hooks.php
New Result :
-
When setting annotation to
* @covers helper::dominant_color_get_dominant_color&* @covers hooks::dominant_color_img_tag_add_dominant_color -
helper.php
hooks.php
So how should I proceed with this since helper.php & hooks.php file don't have a class so ClassName:functionName annotations will not work I also tried adding namespace to helper.php & hooks.php but it results in failing all the test cases and throws error?
cc : @westonruter
There was a problem hiding this comment.
Strange. I don't know why that would be. I also don't understand adding hooks and helper to the beginning of those functions. They would seem to indicate there are classes called hooks and helper, which there aren't.
You're seeing this with local coverage report, but are you also seeing it with the Codecov coverage report?
There was a problem hiding this comment.
They would seem to indicate there are classes called hooks and helper, which there aren't.
Exactly, still for some reason it seems to work.
You're seeing this with local coverage report, but are you also seeing it with the Codecov coverage report?
Yes, in Codecov coverage report also the same is happening.
There was a problem hiding this comment.
@sarthak-19 can you please upload the xml coverage report? maybe that can help analyze how code coverage driver is looking for things?
There was a problem hiding this comment.
@thelovekesh Here's the link to xml report : https://drive.google.com/drive/folders/1Mj8KLo6IcnqsYstaZkRekREtkBzn0-9z?usp=sharing
| @@ -91,7 +91,7 @@ public function test_has_transparency_metadata( string $image_path, array $expec | |||
| * | |||
| * @dataProvider provider_get_dominant_color | |||
| * | |||
| * @covers ::dominant_color_get_dominant_color | |||
| * @covers helper::dominant_color_get_dominant_color | |||
There was a problem hiding this comment.
| * @covers helper::dominant_color_get_dominant_color | |
| * @covers ::dominant_color_get_dominant_color |
| @@ -113,7 +113,7 @@ public function test_dominant_color_has_transparency( string $image_path, array | |||
| * | |||
| * @dataProvider provider_get_dominant_color | |||
| * | |||
| * @covers ::dominant_color_img_tag_add_dominant_color | |||
| * @covers hooks::dominant_color_img_tag_add_dominant_color | |||
There was a problem hiding this comment.
| * @covers hooks::dominant_color_img_tag_add_dominant_color | |
| * @covers ::dominant_color_img_tag_add_dominant_color |
| @@ -199,7 +199,7 @@ public function data_dominant_color_img_tag_add_dominant_color_requires_proper_q | |||
| * | |||
| * @dataProvider data_provider_dominant_color_check_inline_style | |||
| * | |||
| * @covers ::dominant_color_img_tag_add_dominant_color | |||
| * @covers hooks::dominant_color_img_tag_add_dominant_color | |||
There was a problem hiding this comment.
| * @covers hooks::dominant_color_img_tag_add_dominant_color | |
| * @covers ::dominant_color_img_tag_add_dominant_color |
plugins/dominant-color-images/tests/test-dominant-color-image-editor-imagick.php
Outdated
Show resolved
Hide resolved
westonruter
added
the
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @[email protected]. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Summary
This is part of #1789:
@coversAnnotationscc : @westonruter